- Notifications
You must be signed in to change notification settings - Fork1
Support for toolbox 2.6.0.38881#20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fioan89 commentedMar 4, 2025
- localization support is now mandatory
- initial support for gradle toolbox plugin (structure)
- reworked tasks for building the jar and zips- plugin metadata (i.e. extension.json) is now generated by the gradle tasks
- initial support for localization which is now mandatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A few comments on mixing plugin and extension notation but LGTM.
Uh oh!
There was an error while loading.Please reload this page.
| changelog { | ||
| version.set(pluginVersion) | ||
| version.set(extension.version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we want to call plugin an extension from now on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
WIP but indeed it is confusing me as well (especially when "extension" has a different meaning in the context of JetBrains plugins). It is the "nomenclature" used by JetBrains in the sample. I will refactor and simplify some of the things once I have the code working. Bear in mind that this is a wip for now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we should probably involve the JetBrains team. At least share the confusion wit them.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
- fix initial batch of compiler errors- mostly strings converted to LocalizedString instances- while some observable properties are now moved to Kotlin's StateFlow
- fix compiler errors for the Settings page- associated strings converted to LocalizedString instances- observable properties are now moved to Kotlin's StateFlow
- fix compiler errors for Coder main page- associated strings converted to LocalizedString instances- observable properties are now moved to Kotlin's StateFlow
- fix compiler errors for the intro page- associated strings converted to LocalizedString instances- observable properties are now moved to Kotlin's StateFlow
- fix compiler errors for the Sign-In page- associated strings converted to LocalizedString instances- observable properties are now moved to Kotlin's StateFlow
- the jars were not included in the Toolbox install location nor in the zip file- the plugin needs extension.json (which is now autogenerated but initially it was only part of the zip file) so that later it can read the version. With this patch - the json is also included in the jar file
- proper usage of coroutine's stateflow to update values- also fixed issues were state transition were not properly rendered
- service dependencies were resolved all over the place making refactoring harder- it promoted implicit, hidden dependencies- and also introduced tighter coupling between components.- in some cases we had to provide some i18n strings from upstream because the localization service was not available in the constructor. With this patch we resolve all the needed services during plugin load, wrap them in a context and inject the context via the constructor. It is now easier to refactor and the number of constructor parameters has been reduced.
- JetBrains recommendation is to use its own diagnostic logger available via service locator- gets rid of slf4j api library
- in Java/Kotlin, the resources folder is a directory used to store non-code files that are needed by an application at runtime.- in Maven/Gradle world, the resources folder is typically located under: * src/main/resources/ * src/test/resources/
- should be jetbrains-plugin@coder.com
nitpick: I think we should not show the Coder icon with all workspaces. |
fioan89 commentedMar 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@matifali I can make make it disappear, however I think it makes things worse. The text is now weirdly aligned with no control on our side how the layout looks or is aligned. Best case scenario I can try to emulate something like ssh plugin does where a green badge is rendered over the running machines. I'm not sure how is that done because the API made available by JetBrains allows only one icon for all env. However I can skim through Toolbox internal code and see what is JetBrains doing. I propose we merge this PR and address the styling issues in a separate PR. What do you think? |
Yes, please. |
8f1d3a3 intomainUh oh!
There was an error while loading.Please reload this page.