- Notifications
You must be signed in to change notification settings - Fork1
fix: relaxed SNI hostname resolution#197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When establishing TLS connections, SNI resolution may fail if the configured altHostname contains `_` orany other characters not allowed by domain name standards (i.e. letters, digits and hyphens).This change introduces a relaxed SNI resolution strategy which ignores the LDH rules completely.Because this change goes hand in hand with auth. via certificates, I was able to reproduce the issueonly via UTs. At this point the official Coder releases supports only auth. via API keys.
code-asher approved these changesSep 22, 2025
Uh oh!
There was an error while loading.Please reload this page.
c00704d intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When establishing TLS connections, SNI resolution may fail if the configured altHostname contains
_or any other characters not allowed by domain name standards (i.e. letters, digits and hyphens).This change introduces a relaxed SNI resolution strategy which ignores the LDH rules completely. Because this change goes hand in hand with auth. via certificates, I was able to reproduce the issue only via UTs. At this point the official Coder releases supports only auth. via API keys.