- Notifications
You must be signed in to change notification settings - Fork1
fix: don't store token when certificates are configured#192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This was a regression for the custom flows that required authentication via certificates,the http client and the coder cli were properly initialized but afterward the token wasstill required for storing.Note: the issue was hard to catch early on because the official coder cli is not supporting auth. via certificates.
Poll jobs now have a random friendly name that changes each timea new job is created, and the logging for when the jobs are createdor cancelled is also improved. The idea behind this commit is to improvedebugging sessions on client logs by:- having clear log lines saying when a job is created/destructed- easy to remember and cross-match job names (instead of cryptic java reference values)
Seems like we can't properly get the coroutine name from a Job.The name of the coroutine is not super friendly but still workable withthe new logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me but was this causing a bug or something? Looks like it would just store a blank string in the secrets store which seems like it would essentially just be a no-op.
code-asher commentedSep 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Trippy! Ohhh and I thought a blank value would call |
6b00191
intomainUh oh!
There was an error while loading.Please reload this page.
This was a regression for the custom flows that required authentication via certificates, the http client and the coder cli were properly initialized but afterward the token was still required for storing.
Note: the issue was hard to catch early on because the official coder cli is not supporting auth. via certificates.