- Notifications
You must be signed in to change notification settings - Fork1
fix: relaxed Content-Type checks for CLI download#189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR fixes download failure for Windows .exe binaries by relaxing strict Content-Type checks.Previously, the plugin only accepted application/octet-stream, causing failures when .exe fileswere served as application/x-msdos-executable by some servers.-resolves#187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Wow who knew there were so many lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for quickly fixing this. Good catch.
c2d658b intomainUh oh!
There was an error while loading.Please reload this page.
This PR fixes download failure for Windows .exe binaries by relaxing strict Content-Type checks. Previously, the plugin only accepted application/octet-stream, causing failures when .exe files were served as application/x-msdos-executable by some servers.