fix: NPE during error reporting#186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fioan89 merged 2 commits intomainfromfix-npe-during-error-reporting

Sep 2, 2025

Merged

fix: NPE during error reporting#186

fioan89 merged 2 commits intomainfromfix-npe-during-error-reporting

Sep 2, 2025

Conversation

Copy link

Collaborator

fioan89 commentedAug 28, 2025

The try/catch block raised NPE in thenotify if another exception was raised after the context containing the URL was reset - so that means an error in the onConnect handler. In addition, some of the reset steps were moved after onConnect to make sure they execute only if onConnect callback is successful.

Because of the fault in how the steps were arranged, the original exception was never logged instead a misleading NPE was treated by the coroutine's exception handler.

fix: NPE during error reporting

837abb3

The try/catch block raised NPE in the `notify` if another exception was raisedafter the context containing the URL was reset - so that means an error in the onConnecthandler. In addition, some of the reset steps were moved after onConnect to make sure theyexecute only if onConnect callback is successful.Because of the fault in how the steps were arranged, the original exception was never loggedinstead a misleading NPE was treated by the coroutine's exception handler.

fioan89 requested review frommatifali,code-asher andf0ssel

August 28, 2025 21:56

Copy link

CollaboratorAuthor

fioan89 commentedAug 28, 2025

I'm putting this on draft because when I tried to test a scenario where onConnect raised an exception Toolbox refused to show the snackbar with the error requested by thenotify. I think it has something to do with calling lambdas passed as method references in the coroutines that are cancelled in the end. If I replace the "notify" with a simple showSnackbar call everything is fine. Of course, notify does a bit more than that so I need to either find a nother way to share/reuse that implementation in a different way, or understand why method references don't work too well in coroutines that become canceled.