Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

impl: improved debugging with named coroutines and additional logging#185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 8 commits intomainfromimpl-improve-diagnose
Aug 28, 2025

Conversation

fioan89
Copy link
Collaborator

  • this commit add descriptive names to launched coroutines for better stack traces.
  • extra logging lines during connection setup. Should be helpful in cases where the coroutines
    fail with exceptions

code-asher reacted with hooray emoji
This commit add descriptive names to launched coroutines for better stack traces.
SSH config manipulation is a heavy operation that involves disk writing andcan take long time. Logs are added so that we can easily identify when the sshconfiguration writing is done.
During plugin initialization we have a couple of steps that are only reported in the screen.If there is any error happening in between the steps, it is hard to identify between which stepsthings went wrong without a screenshots provided by the user.
@fioan89fioan89 marked this pull request as ready for reviewAugust 26, 2025 22:58
Calling onBack() in the exception handler doesn't make sense because:- the coroutine is already interrupted by the exception- onBack() is meant to handle user-initiated back navigation, not error recovery- we still want the proper navigation logic but without the coroutine cancellation part
@fioan89fioan89 merged commit22f53f6 intomainAug 28, 2025
6 checks passed
@fioan89fioan89 deleted the impl-improve-diagnose branchAugust 28, 2025 20:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@f0sself0sself0ssel approved these changes

@code-ashercode-ashercode-asher approved these changes

@matifalimatifaliAwaiting requested review from matifali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@fioan89@f0ssel@code-asher

[8]ページ先頭

©2009-2025 Movatter.jp