- Notifications
You must be signed in to change notification settings - Fork1
impl: improved debugging with named coroutines and additional logging#185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This commit add descriptive names to launched coroutines for better stack traces.
SSH config manipulation is a heavy operation that involves disk writing andcan take long time. Logs are added so that we can easily identify when the sshconfiguration writing is done.
During plugin initialization we have a couple of steps that are only reported in the screen.If there is any error happening in between the steps, it is hard to identify between which stepsthings went wrong without a screenshots provided by the user.
f0ssel approved these changesAug 27, 2025
code-asher approved these changesAug 27, 2025
Uh oh!
There was an error while loading.Please reload this page.
Calling onBack() in the exception handler doesn't make sense because:- the coroutine is already interrupted by the exception- onBack() is meant to handle user-initiated back navigation, not error recovery- we still want the proper navigation logic but without the coroutine cancellation part
22f53f6
intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fail with exceptions