- Notifications
You must be signed in to change notification settings - Fork1
impl: report progress while handling URI#180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Up until now there was no progress while downloading CLI, setting up the cli and the ssh configwhile handling URIs. This PR reworks the uri handler and the connection screen to be able to reusethe later part in the URI handler. This should improve the experience because the user is no longerleft in the dark for a good couple of seconds.
matifali approved these changesAug 23, 2025
f0ssel approved these changesAug 25, 2025
URI handling now jumps back to main plugin page when the connectionto the url in the URI fails.
0852d88 intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
fioan89 added a commit that referenced this pull requestOct 2, 2025
PR#180 delegated all the logic for rest client and cliinitialization to the usual authentication screen which providedbetter feedback/progress. But it also left over previous logicthat can be removed.
fioan89 added a commit that referenced this pull requestOct 3, 2025
PR#180 delegated all the logic for rest client and cli initializationto the usual authentication screen which provided betterfeedback/progress. But it also left over previous logic that can beremoved.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now there was no progress while downloading CLI, setting up the cli and the ssh config while handling URIs. This PR reworks the uri handler and the connection screen to be able to reuse the later part in the URI handler. This should improve the experience because the user is no longer left in the dark for a good couple of seconds.