- Notifications
You must be signed in to change notification settings - Fork1
fix: support for downloading the CLI when proxy is configured#177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The commit will allow later the reuse of the same http client setup (or similarbecause some of the interceptors will not be the same) for CLI downloading
The objective is to be able to reuse the interceptors from multiple places.
Proxy support is enabled for every upstream usage
Until this commit, the CLI download manager relied on a separately configured HTTPclient that lacked proxy support, unlike the REST client which was refactored and modularized.Now we have the same support for proxy and a proper user agent and custom logging interceptor.
matifali approved these changesAug 19, 2025
acd0578 intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
I've raisedhttps://youtrack.jetbrains.com/issue/TBX-15928/General-text-input-dialogs-are-rendered-as-password-input-fields to fix the issue. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until this commit, the CLI download manager relied on a separately configured HTTP
client that lacked proxy support, unlike the REST client which was refactored and modularized.
Now we have the same support for proxy and a proper user agent and custom logging interceptor.