- Notifications
You must be signed in to change notification settings - Fork1
fix: enforce Content-Type to accept only binary responses#174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Add validation for CLI downloads that ensures the Content-Type headeris indicating a binary stream (`application/octet-stream`),including common variants with parameters. This prevents saving unexpectedHTML or other non-binary responses (e.g., from frontend dev servers on :8080)as binaries, improving reliability and providing clearer error feedback.
fioan89 commentedAug 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
 I think this provides a better message compared to the previous message which hided the actual issue (html page downloaded into a file with the name of the cli, with the fake cli failing to execute) |
which now expect Content-Type to be present on the response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
a923f58 intomainUh oh!
There was an error while loading.Please reload this page.
Add validation for CLI downloads that ensures the Content-Type header is indicating a binary stream (
application/octet-stream), including common variants with parameters. This prevents saving unexpected HTML or other non-binary responses (e.g., from frontend dev servers on :8080) as binaries, improving reliability and providing clearer error feedback.