When the plugin is upgraded while JBClient is connected to a remote dev server via the Coder SSH proxy/tunnel,the upgrade process kills and re-establishes the SSH connection. However, JBClient/Toolbox fails to detect the restoredconnection and reports "Toolbox: Target environment com.coder.toolbox:bobiverse-bob.dev not found" error.While digging into the Toolbox bytecode—specifically ClientOverSshTunnelConnector—I realized the issue likely stemsfrom an incorrect equals implementation in our custom SSH connection info object. In short, when a plugin upgrade terminatesthe SSH tunnel, the connector’s monitoring logic correctly detects the lost connection and waits. But when the SSH connectionis re-established, the monitoring logic fails to recognize it as a valid replacement, because equals is still using thedefault Object#equals rather than a proper value-based implementation.Unfortunately, I wasn’t able to properly test this—specifically, upgrading from a version without the fix to one that includesit—because all Toolbox marketplace feeds are signed, preventing us from using a tool like mitmproxy to serve a locally modifiedplugin version. Given that, I propose releasing the change first and then performing the upgrade test to confirm the fix.

code-asher left a comment