- Notifications
You must be signed in to change notification settings - Fork1
impl: add support for disabling CLI signature verification#166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
These options are configurable from the Settings page, there is no availableshortcut on the main plugin page to discourage the quick disable of CLI verification
The main plugin screen has a quick shortcut for setting whether the userwants to fallback on releases.coder.com for signatures if they are not provided bythe main deployment. This checkbox should not be visible if the user wants to disablesignature verification altogether.To make things more consistent with Coder Gateway, the fallback setting is always displayedif signature verification is enabled, we no longer display it only once in the main page.
Signature validation is skipped if the user configured the `disableSignatureVerification` to true.
matifali approved these changesJul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
jdomeracki-coder approved these changesJul 31, 2025
jdomeracki-coder left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works as expected ✅
0ad31dd intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR implements a new configurable option to allow users to disable GPG signature verification for downloaded Coder CLI binaries. This feature provides flexibility for environments where signature verification may not be required or where fallback signature sources are not accessible.
A new option
disableSignatureVerificationis now available only from the Settings page, with no quick shortcut in the main page to discourage users from quickly disabling this option. ThefallbackOnCoderForSignaturesis hidden/not available for configuration once signature verification is disabled.Additionally a rough draft for developer facing documentation regarding CLI signature verification was added.
To make things more consistent with Coder Gateway, the fallback setting is always displayed if signature verification is enabled, we no longer display it only once in the main page.
This PR is a port ofcoder/jetbrains-coder#564 from Coder Gateway.
