- Notifications
You must be signed in to change notification settings - Fork1
impl: strict URL validation#164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This commit rejects any URL that is opaque, not hierarchical, not using http or httpsprotocol, or it misses the hostname. The rejection is handled in the connection/auth screenand also in the URI protocol handling logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could we make the error message a bit more explicit with an example of a correct URL? I think some of the users may not know what an opaque or hierarchical URL is.
Done. |
82eee1f intomainUh oh!
There was an error while loading.Please reload this page.
This commit rejects any URL that is opaque, not hierarchical, not using http or https protocol, or it misses the hostname. The rejection is handled in the connection/auth screen and also in the URI protocol handling logic
