- Notifications
You must be signed in to change notification settings - Fork4
fix: class cast exception when handling Failed verification result & signature download on Windows#158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fioan89 merged 4 commits intomainfromfix-class-cast-exception-when-handling-failed-resultJul 22, 2025
Merged
fix: class cast exception when handling Failed verification result & signature download on Windows#158
fioan89 merged 4 commits intomainfromfix-class-cast-exception-when-handling-failed-resultJul 22, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
verification result was improperly cast to download result when signatureverification failed to run.
The signature for windows CLI follows the format: coder-windows-amd64.exe.ascCurrently it is coded to coder-windows-amd64.asc which means the pluginalways fail to find any signature for windows cli
code-asher approved these changesJul 22, 2025
1f23762 intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Verification result was improperly cast to download result when signature verification failed to run.
I discovered this issue while porting the signature verifications to Coder Gateway plugin.
Additionally the signature for windows CLI follows the format: coder-windows-amd64.exe.asc
Currently it is coded to coder-windows-amd64.asc which means the plugin always fail to find any signature for windows CLI