- Notifications
You must be signed in to change notification settings - Fork1
impl: verify cli signature#148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+1,230 −322
Merged
Changes fromall commits
Commits
Show all changes
43 commits Select commitHold shift + click to select a range
4227ebd
impl: new UI setting for running unsigned binary execution
fioan89021e53a
chore: refactor CLI downloading logic
fioan89fb6e784
impl: support for downloading the cli signature
fioan89dbf8560
impl: support for downloading the releases.coder.com signature
fioan896754300
fix: read fresh values from the config store
fioan898d768ee
impl: prompt user when running unsigned binaries
fioan89ea3e379
fix: used proper result to verify if signature is downloaded
fioan893668d46
chore: compact code and run signature download on the IO thread
fioan89a476364
chore: add support for bouncycastle
fioan8945a72fb
chore: update i18n bundle with new strings related to signature verif…
fioan89ad44346
impl: verify gpg signed cli binaries
fioan894cd5148
impl: embed the pgp public key as a plugin resource
fioan89fbe68de
impl: load the public key from a resource file
fioan89270b949
impl: run the signature verification on the IO thread
fioan89d5ae289
fix: find the key id in multiple key rings
fioan8996663e6
fix: remove the cli if it is not properly signed
fioan896a79995
fix: avoid out of memory when verifying signatures
fioan895fcb4b9
fix: don't run signature verification
fioan893543377
chore: fix UTs
fioan890a5de76
Merge branch 'main' into impl-verify-cli-signature
fioan8997dbc8d
chore: next version is 0.5.0
fioan8927066d8
fix: more UTs
fioan89811fc85
fix: display errors that happened while handling URIs
fioan899851dec
impl: check if the cli exists before running it to spill out the version
fioan89306848f
impl: download retroactive cli signatures from releases.coder.com/cod…
fioan895dcdff0
fix: UTs after fallback to signatures from releases.coder.com were pu…
fioan895bf0792
chore: refactor code around signature name
fioan89bce103b
chore: remove code around URL building
fioan898342a21
fix: raise the original error when cli can't be downloaded
fioan89881a662
impl: download the cli to a temporary location
fioan89aeb79e5
impl: prompt the user if when signature verification fails
fioan89f57c07d
impl: introduce signature fallback setting
fioan89dcba5ec
impl: ask the user only once in the login screen for fallback strategy
fioan89a8767d2
fix: the settings page doesn't see changes done from other screens
fioan890ad2121
impl: prompt user for allowing unverified binaries to run
fioan89eba8118
chore: always run unsigned binaries in the UTs
fioan8926a94c1
Merge branch 'main' into impl-verify-cli-signature
fioan893856d57
fix: fallback to releases.coder.com was not properly treated
fioan8965eb1ec
fix: report cli download progress with the real name
fioan89736325e
fix: don't report version for signatures while downloading
fioan895ea0967
impl: improve progress reporting while downloading the cli
fioan896529069
chore: improve fallback setting text
fioan8953d5b32
fix: don't send custom request headers when accessing release.coder.com
fioan89File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletionsCHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletionsbuild.gradle.kts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletiongradle.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
version=0.5.0 | ||
group=com.coder.toolbox | ||
name=coder-toolbox |
4 changes: 4 additions & 0 deletionsgradle/libs.versions.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
59 changes: 40 additions & 19 deletionssrc/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.