coder/coder-jetbrains-toolboxPublic

NotificationsYou must be signed in to change notification settings
Fork4
Star12

impl: add support for matching agent by name#146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fioan89 merged 3 commits intomainfromimpl-lookup-agent-by-name

Jul 8, 2025

Merged

impl: add support for matching agent by name#146

fioan89 merged 3 commits intomainfromimpl-lookup-agent-by-name

Jul 8, 2025

Conversation

Copy link

Collaborator

fioan89 commentedJul 7, 2025

This PR adds support for matching workspace agent in the URI via theagent_name query param. The existing support foragent_id is dropped and replaced by the new param.

fioan89 added2 commits

July 7, 2025 23:50

impl: add support for matching agent by name

ded84d6

This PR adds support for matching workspace agent in the URI via the `agent_name` query param.The existing support for `agent_id` is dropped and replaced by the new param.

fix: update UTs related to agent resolution in the URI handling

e8b0d34

fioan89 marked this pull request as ready for review

July 7, 2025 21:23

fioan89 requested review fromcode-asher,f0ssel andmatifali

July 7, 2025 21:23

code-asher approved these changes

Jul 7, 2025

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

README.md OutdatedShow resolvedHide resolved

matifali approved these changes

Jul 8, 2025

View reviewed changes

Copy link

Member

matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few suggestions to docs but LGTM.

README.mdShow resolvedHide resolved

README.md Outdated

		jetbrains://gateway/com.coder.toolbox?url=https%3A%2F%2Fdev.coder.com&token=zeoX4SbSpP-j2qGpajkdwxR9jBdcekXS2&workspace=bobiverse-bob&agent_name=dev&ide_product_code=GO&ide_build_number=241.23774.119&folder=%2Fhome%2Fcoder%2Fworkspace%2Fhello-world-rs

		jetbrains://gateway/com.coder.toolbox?url=https%3A%2F%2Fj5gj2r1so5nbi.pit-1.try.coder.app%2F&token=gqEirOoI1U-FfCQ6uj8iOLtybBIk99rr8&workspace=bobiverse-riker&agent=dev&ide_product_code=RR&ide_build_number=243.26053.17&folder=%2Fhome%2Fcoder%2Fworkspace%2Fhello-world-rs
		jetbrains://gateway/com.coder.toolbox?url=https%3A%2F%2Fj5gj2r1so5nbi.pit-1.try.coder.app%2F&token=gqEirOoI1U-FfCQ6uj8iOLtybBIk99rr8&workspace=bobiverse-riker&agent_name=dev&ide_product_code=RR&ide_build_number=243.26053.17&folder=%2Fhome%2Fcoder%2Fworkspace%2Fhello-world-rs

Copy link

Member

matifaliJul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	jetbrains://gateway/com.coder.toolbox?url=https%3A%2F%2Fj5gj2r1so5nbi.pit-1.try.coder.app%2F&token=gqEirOoI1U-FfCQ6uj8iOLtybBIk99rr8&workspace=bobiverse-riker&agent_name=dev&ide_product_code=RR&ide_build_number=243.26053.17&folder=%2Fhome%2Fcoder%2Fworkspace%2Fhello-world-rs
	jetbrains://gateway/coder?url=https%3A%2F%2Fj5gj2r1so5nbi.pit-1.try.coder.app%2F&token=gqEirOoI1U-FfCQ6uj8iOLtybBIk99rr8&workspace=bobiverse-riker&agent_name=dev&ide_product_code=RR&ide_build_number=243.26053.17&folder=%2Fhome%2Fcoder%2Fworkspace%2Fhello-world-rs