- Notifications
You must be signed in to change notification settings - Fork1
impl: visual text progress during Coder CLI downloading#130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The REST client doesn't do any authentication but ratherretrieves the user and build info - the user is alreadyauthenticated via the API token. So `authenticate` is misleading here.
This PR implements a mechanism to provide recurrent stats aboutthe number of the KB and MB of Coder CLI downloaded.
Keeps the previous behavior which was removing the binary before download.
This is how the download progress looks like.
Screen.Recording.2025-06-17.at.23.12.36.mov |
@matifali I was thinking that we should also change the title from |
We also don't do any setting up. |
We download the cli, we initialize the cli with the token, re-generate the ssh config file, initialize a rest client with the deployment url and the token and retrieve basic information about the deployment like the version and the user authenticated by the token. The three pages wizard from the video needs a title which is why I proposed to compress all of the steps I just mentioned in a "Setting up Coder" title. I'm open for any suggestions regarding the title. |
@matifali what do you think?
Screen.Recording.2025-06-18.at.23.05.46.mp4 |
Alongside the content size downloaded
We are not really doing authentication, instead we download the cli,we initialize the cli with the token, re-generate the ssh config file,initialize a rest client with the deployment url and the token andretrieve basic information about the deployment like the version andthe user authenticated by the token.
improved flow. Screen.Recording.2025-06-18.at.23.36.46.mp4 |
matifali left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks great ❤️
2eb4848 intomainUh oh!
There was an error while loading.Please reload this page.
This PR implements a mechanism to provide recurrent stats about the number of the KB and MB of Coder CLI downloaded.