impl: remember the ssh connection state#125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fioan89 merged 4 commits intomainfromfix-auto-connect-when-token-expires

Jun 12, 2025

Merged

impl: remember the ssh connection state#125

fioan89 merged 4 commits intomainfromfix-auto-connect-when-token-expires

Jun 12, 2025

Conversation

Copy link

Collaborator

fioan89 commentedJun 3, 2025

And try to automatically establish the connections after an expired token was refreshed (by going again through the login sequence)

In addition a fix was provided in order to show errors when TBX is visible after being minimized. Errors encountered while TBX was running but the window was not visible were never displayed by TBX. This fix queues the errors while TBX is minimized, and they will be displayed again only when visible. This implementation is possible due to an observable
state object that can provide information about TBX and plugin visibility.

Among other things we also display a more human friendly version for the exceptions raised by the http client during (but not only) workspace polling.

Attention: users will still have to manually launch a new a remote IDE if it was opened while a session expired.

resolvesAsk for token if it expires during a connection #121

fioan89 added3 commits

June 3, 2025 23:16

fix: show errors when TBX is visible after being minimized

e1e525b

Errors encountered while TBX was running but the window was not visible were neverdisplayed by TBX. This fix queues the errors while TBX is minimized, and they will bedisplayed again only when visible. This implementation is possible due to an observablestate object that can provide information about TBX and plugin visibility.Among other things we also display a more human friendly version for the exceptionsraised by the http client during (but not only) workspace polling.

fix: force auto-login when error is encountered during polling

1c3795a

impl: remember the ssh connection state

52171c2

And try to automatically establish the connections after an expired token was refreshed (by going againthrough the login sequence)Users will still have to launch a new a remote IDE if it was opened while a session expired.-resolves#121

fioan89 requested review frommatifali andf0ssel

June 3, 2025 22:05

Copy link

Member

matifali commentedJun 4, 2025•
edited
Loading

Can we hook into OS notifications for some of the important errors?

Copy link

CollaboratorAuthor

fioan89 commentedJun 4, 2025•
edited
Loading

Can we hook into OS notifications for some of the important errors?

Can you expand on this? I'm not entirely sure what do you mean, maybe some examples of errors that we want to treat? Right now token expiration triggers the ssh re-connection.