- Notifications
You must be signed in to change notification settings - Fork1
impl: remember the ssh connection state#125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
fioan89 wants to merge3 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Errors encountered while TBX was running but the window was not visible were neverdisplayed by TBX. This fix queues the errors while TBX is minimized, and they will bedisplayed again only when visible. This implementation is possible due to an observablestate object that can provide information about TBX and plugin visibility.Among other things we also display a more human friendly version for the exceptionsraised by the http client during (but not only) workspace polling.
And try to automatically establish the connections after an expired token was refreshed (by going againthrough the login sequence)Users will still have to launch a new a remote IDE if it was opened while a session expired.-resolves#121
Member
matifali commentedJun 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can we hook into OS notifications for some of the important errors? |
Can expand on this? I'm not entirely sure what do you mean, maybe some examples of errors that we want to treat? Right now token expiration triggers the ssh re-connection. |
f0ssel approved these changesJun 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And try to automatically establish the connections after an expired token was refreshed (by going again through the login sequence)
In addition a fix was provided in order to show errors when TBX is visible after being minimized. Errors encountered while TBX was running but the window was not visible were never displayed by TBX. This fix queues the errors while TBX is minimized, and they will be displayed again only when visible. This implementation is possible due to an observable
state object that can provide information about TBX and plugin visibility.
Among other things we also display a more human friendly version for the exceptions raised by the http client during (but not only) workspace polling.
Attention: users will still have to manually launch a new a remote IDE if it was opened while a session expired.