Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

impl: remember the ssh connection state#125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
fioan89 wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromfix-auto-connect-when-token-expires

Conversation

fioan89
Copy link
Collaborator

And try to automatically establish the connections after an expired token was refreshed (by going again through the login sequence)

In addition a fix was provided in order to show errors when TBX is visible after being minimized. Errors encountered while TBX was running but the window was not visible were never displayed by TBX. This fix queues the errors while TBX is minimized, and they will be displayed again only when visible. This implementation is possible due to an observable
state object that can provide information about TBX and plugin visibility.

Among other things we also display a more human friendly version for the exceptions raised by the http client during (but not only) workspace polling.

Attention: users will still have to manually launch a new a remote IDE if it was opened while a session expired.

Errors encountered while TBX was running but the window was not visible were neverdisplayed by TBX. This fix queues the errors while TBX is minimized, and they will bedisplayed again only when visible. This implementation is possible due to an observablestate object that can provide information about TBX and plugin visibility.Among other things we also display a more human friendly version for the exceptionsraised by the http client during (but not only) workspace polling.
And try to automatically establish the connections after an expired token was refreshed (by going againthrough the login sequence)Users will still have to launch a new a remote IDE if it was opened while a session expired.-resolves#121
@fioan89fioan89 requested review frommatifali andf0sselJune 3, 2025 22:05
@matifali
Copy link
Member

matifali commentedJun 4, 2025
edited
Loading

Can we hook into OS notifications for some of the important errors?

@fioan89
Copy link
CollaboratorAuthor

Can we hook into OS notifications for some of the important errors?

Can expand on this? I'm not entirely sure what do you mean, maybe some examples of errors that we want to treat? Right now token expiration triggers the ssh re-connection.

matifali reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifaliAwaiting requested review from matifali

@f0sself0sselAwaiting requested review from f0ssel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ask for token if it expires during a connection
2 participants
@fioan89@matifali

[8]ページ先頭

©2009-2025 Movatter.jp