Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: url refresh after switching deployments#119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 1 commit intomainfromfix-url-refresh-after-switching-deployments
May 23, 2025

Conversation

fioan89
Copy link
Collaborator

The main env header page API is quite limiting, in the sense that the title is never allowed to change. Today we display the Coder URL as the title. However, if the user switches between two deployments via log out and then log in, the URL is never refreshed, leading to a confusing UI (URL is old, while workspaces are from the new deployment)

JetBrains suggested a workaround inhttps://youtrack.jetbrains.com/issue/TBX-14421/ by creating a new env page instance with the updated title after each deployment switch. In which case Toolbox redraws the main screen when page state changes.
I tested the workaround and indeed it works but with a caveat. The new env page is refreshed only when Toolbox window page is made visible or when navigating from main env page to a single env page and then back to the main page. For some reason, if we callenvPageManager.showPluginEnvironmentsPage()`` from the authentication page displayed ingetOverrideUiPage() it doesn't trigger the new env refresh giving the false impression that the URL won't change. In fact this was the reason why I missed this workaround in previously.

It is interesting that if I first navigate to a blank page -toolboxUi.showUiPage(emptyPage) - and then immediately callenvPageManager.showPluginEnvironmentsPage(), doing this rapid sequence seems to do the trick without any visible artifacts (it happens so fast that we can't see the blank page being rendered)

The main env header page API is quite limiting, in the sense that the title is never allowed to change.Today we display the Coder URL as the title. However, if the user switches between two deployments vialog out and then log in, the URL is never refreshed, leading to a confusing UI (URL is old, while workspacesare from the new deployment)JetBrains suggested a workaround inhttps://youtrack.jetbrains.com/issue/TBX-14421/ by creating a new envpage instance with the updated title after each deployment switch. In which case Toolbox redraws the mainscreen when page state changes.I tested the workaround and indeed it works but with a caveat. The new env page is refreshed only whenToolbox window page is made visible or when navigating from main env page to a single env page and thenback to the main page. For some reason, if we call `envPageManager.showPluginEnvironmentsPage()`` from theauthentication page displayed in `getOverrideUiPage() it doesn't trigger the new env refresh giving thefalse impression that the URL won't change. In fact this was the reason why I missed this workaround in previously.It is interesting that if I first navigate to a blank page - `toolboxUi.showUiPage(emptyPage)` - and thenimmediately call `envPageManager.showPluginEnvironmentsPage()`, doing this rapid sequence seems to do thetrick without any visible artifacts (it happens so fast that we can't see the blank page being rendered)-resolves#66
@fioan89fioan89 requested review frommatifali andf0sselMay 22, 2025 20:28
@fioan89
Copy link
CollaboratorAuthor

Screen.Recording.2025-05-22.at.23.13.17.mov

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Maybe we should ask someone from JetBrains team to review.

@fioan89
Copy link
CollaboratorAuthor

I have a private conversation with Evgenii Bulavin from JetBrains and I asked there for review.

matifali reacted with thumbs up emoji

@fioan89fioan89 merged commite4ce4c4 intomainMay 23, 2025
5 checks passed
@fioan89fioan89 deleted the fix-url-refresh-after-switching-deployments branchMay 23, 2025 18:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployment URL is not refreshed after log out and login to another deployment
2 participants
@fioan89@matifali

[8]ページ先頭

©2009-2025 Movatter.jp