Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

impl: workspace status reporting (color and icons)#118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 2 commits intomainfromimprove-workspace-state-reporting
May 22, 2025

Conversation

fioan89
Copy link
Collaborator

@fioan89fioan89 commentedMay 21, 2025
edited
Loading

There were a couple of discrepancies in the status reporting especially around icons and colors:

  • offline workspaces are marked by a new "offline" icon and a gray color (instead of a half pie icon with a red color)
  • stopping state now has a gray progress spinner
  • same for deleting state which previously used the offline icon instead of the spinner.
  • failed workspaces used to render a gray offline icon instead of a red warning (exclamation mark) sign.
  • there was no progress while establishing the SSH connection. Now we have a "SSHing" label with a circular progress bar while connecting to the SSH.

There were a couple of discrepancies in the status reporting especiallyaround icons and colors:- offline workspaces are marked by a new "offline" icon and a gray color (instead of a half pie icon  with a red color)- stopping state now has a gray progress spinner- same for deleting state which previously used the offline icon instead of the spinner.- there was no progress while establishing the SSH connection. Now we have a "SSHing" label with a circular  progress bar while connecting to the SSH.
@fioan89fioan89 requested review fromf0ssel andmatifaliMay 21, 2025 21:47
@fioan89
Copy link
CollaboratorAuthor

A couple of screenshots with the new statuses:
Screenshot 2025-05-22 at 00 52 37
Screenshot 2025-05-22 at 00 51 36
Screenshot 2025-05-22 at 00 49 19
Screenshot 2025-05-22 at 00 47 56

@matifali
Copy link
Member

Could we also specify a red warning icon for Failed state?

Failed workspaces used a gray offline icons. Instead, we now render ared warning icon (exclamation mark).
@fioan89
Copy link
CollaboratorAuthor

Indeed I've missed that. Previously the failed state was rendered with a gray offline icon. Thx for pointing that out.

Screenshot 2025-05-22 at 21 24 11

matifali reacted with heart emoji

@fioan89fioan89 requested a review frommatifaliMay 22, 2025 18:33
@fioan89fioan89 merged commitfcb9dc7 intomainMay 22, 2025
5 checks passed
@fioan89fioan89 deleted the improve-workspace-state-reporting branchMay 22, 2025 18:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matifalimatifalimatifali approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fioan89@matifali

[8]ページ先頭

©2009-2025 Movatter.jp