- Notifications
You must be signed in to change notification settings - Fork1
impl: workspace status reporting (color and icons)#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There were a couple of discrepancies in the status reporting especiallyaround icons and colors:- offline workspaces are marked by a new "offline" icon and a gray color (instead of a half pie icon with a red color)- stopping state now has a gray progress spinner- same for deleting state which previously used the offline icon instead of the spinner.- there was no progress while establishing the SSH connection. Now we have a "SSHing" label with a circular progress bar while connecting to the SSH.
matifali approved these changesMay 21, 2025
Could we also specify a red warning icon for Failed state? |
Failed workspaces used a gray offline icons. Instead, we now render ared warning icon (exclamation mark).
matifali approved these changesMay 22, 2025
fcb9dc7
intomain 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
There were a couple of discrepancies in the status reporting especially around icons and colors: