- Notifications
You must be signed in to change notification settings - Fork1
fix: open URLs on Windows#116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The URLs on Windows failed to be opened because the cmd executed viaProcessExecutor was not correctly constructed. We were calling `exec("cmd", "start \"$url\"")`but in Windows `/c` is also needed to the `cmd`.We originally used native commands to open URLs because Toolbox didn’t support it.Now that LocalDesktopManager provides an API for launching the browser, we no longer need to fixthe command-line logic — we can just use the Toolbox API instead.I've tested this fix on macOS and Windows. Seems to be fine now. |
matifali approved these changesMay 20, 2025
72c60f6 intomain 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URLs on Windows failed to be opened because the cmd executed via ProcessExecutor was not correctly constructed. We were calling
exec("cmd", "start \"$url\"")but in Windows/cis also needed to thecmd.We originally used native commands to open URLs because Toolbox didn’t support it. Now that LocalDesktopManager provides an API for launching the browser, we no longer need to fix the command-line logic — we can just use the Toolbox API instead.