Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: access the settings page for the auth. wizard#105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 1 commit intomainfromconfigure-settings-from-login-page
May 5, 2025

Conversation

fioan89
Copy link
Collaborator

The Settings menu is only available after we successfully authenticate. This can be somewhat problematic if we want to configure something like coder cli path, or certificate path before doing the authentication.

A new "Settings" button at the bottom of the page can now access the Settings page. Toolbox is a bit inflexible with the API because:

The Settings menu is only available after we successfully authenticate.This can be somewhat problematic if we want to configure something likecoder cli path, or certificate path before doing the authentication.A new "Settings" button at the bottom of the page can now access the Settingspage. Toolbox is a bit inflexible with the API because:- I could not find a way to delimit or separate the Settings button from the Back and Sign In/Connect button- we can't put a button or anything else in the top right corner, the traditional place for a settings icon.-resolves#90
@fioan89fioan89 requested review frommatifali andf0sselMay 2, 2025 21:51
@fioan89
Copy link
CollaboratorAuthor

I'm not entirely happy with how this turned out. Ideally the Settings button would have been separated from the rest, either horizontally or on a different place like the top right corner.

Screenshot 2025-05-03 at 00 02 26
Screenshot 2025-05-03 at 00 03 04
Screenshot 2025-05-03 at 00 05 03

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank Ioan. This is a good enough workaround for now. Can you create a Youtrack issue and report to JB the limitation of UI. Attaching the screenshot should help them understand it better.

@fioan89
Copy link
CollaboratorAuthor

fioan89 commentedMay 5, 2025
edited
Loading

@fioan89fioan89 merged commit97cd0f0 intomainMay 5, 2025
5 checks passed
@fioan89fioan89 deleted the configure-settings-from-login-page branchMay 5, 2025 18:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't configure the Settings from the initial login page
2 participants
@fioan89@matifali

[8]ページ先頭

©2009-2025 Movatter.jp