- Notifications
You must be signed in to change notification settings - Fork1
Support for removing workspaces#10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- biggest issue is that popup dialogs are only visible in the main page so user can only confirm from that place. It can press the delete button even from the workspace details page, but it will have to navigate back to the main page to confirm whether he wants to proceed with the delete action.- the actual delete is not yet implemented
- calls the coder REST API endpoints to remove a workspace id.
- needed otherwise we are going to show a stale workspace in the contents view.- only when workspace changes status to DELETING or DELETED.
- and as a bonus Toolbox is now displaying nice animation around the header bar when workspace is starting or stopping
matifali approved these changesFeb 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Small note: info and error dialogs created with ToolboxUi#showInfoPopup, ToolboxUi#showYesNoPopup, and ToolboxUi#showOkCancelPopup only appear on the main page where all environments are listed. JetBrains is addressing the issue but until then user can interact with the confirmation dialog only from the front page.