Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:coder/coder-jetbrains-toolbox
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base:main
Choose a base ref
Loading
...
head repository:coder/coder-jetbrains-toolbox
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare:impl-support-for-oauth
Choose a head ref
Loading
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13commits
  • 17files changed
  • 1contributor

Commits on Oct 9, 2025

  1. Configuration menu
    Copy the full SHA
    8bfee5eView commit details
    Browse the repository at this point in the history
  2. impl: setup auth manager with auth and token endpoints

    Toolbox API comes with a basic oauth2 client. This commitsets-up details about two important oauth flows:- authorization flow, in which the user is sent to web page  where an authorization code is generated which is exchanged  for an access token.- details about token refresh endpoint where users can obtain  a new access token and a new refresh token.A couple of important aspects:- the client app id is resolved in upstream- as well as the actual endpoints for authorization and token refresh- S256 is the only code challenge supported
    @fioan89
    fioan89 committedOct 9, 2025
    Configuration menu
    Copy the full SHA
    1a3415bView commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2025

  1. impl: retrieve supported response type and the dynamic client registr…

    …ation urlOAuth endpoint `.well-known/oauth-authorization-server` provides metadata aboutthe endpoint for dynamic client registration and supported response types.This commit adds support for deserializing these values.
    @fioan89
    fioan89 committedOct 13, 2025
    Configuration menu
    Copy the full SHA
    7685febView commit details
    Browse the repository at this point in the history
  2. impl: models for dynamic client registration

    OAuth allows programatic client registration for apps like Coder Toolboxvia the DCR endpoint which requires a name for the client app, the requestedscopes, redirect URI, etc... DCR replies back with a similar structure butin addition it returs two very important properties: client_id - a uniqueclient identifier string and also a client_secret - a secret string valueused by clients to authenticate to the token endpoint.
    @fioan89
    fioan89 committedOct 13, 2025
    Configuration menu
    Copy the full SHA
    52648a0View commit details
    Browse the repository at this point in the history
  3. impl: pixy secure code generator

    Code Toolbox plugin should protect against authorization code interceptionattacks by making use of the PKCE security extension which involvesa cryptographically random string (128 characters) known as code verifierand a code challenge - derived from code verifier using the S256 challenge method.
    @fioan89
    fioan89 committedOct 13, 2025
    Configuration menu
    Copy the full SHA
    72a902fView commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e03b03View commit details
    Browse the repository at this point in the history
  5. impl: factory method for the auth manager

    The OAuth2-compatible authentication manager provided by Toolbox
    @fioan89
    fioan89 committedOct 13, 2025
    Configuration menu
    Copy the full SHA
    79ba4cbView commit details
    Browse the repository at this point in the history
  6. impl: improve auth manager config

    - authentication and token endpoints are now passed via the login configuration object- similar for client_id and client_secret- PCKE is now enabled
    @fioan89
    fioan89 committedOct 13, 2025
    Configuration menu
    Copy the full SHA
    59d2abdView commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2025

  1. refactor: simplify OAuth manager architecture and improve dependency …

    …injection- remove ServiceLocator dependency from CoderToolboxContext- move OAuth manager creation to CoderToolboxExtension for cleaner separation- Refactor CoderOAuthManager to use configuration-based approach instead of constructor injectionThe idea behind these changes is that createRefreshConfig API does not receive a configurationobject that can provide the client id and secret and even the refresh url. So initiallywe worked around the issue by passing the necessary data via the constructor. However this approachmeans a couple of things:- the actual auth manager can be created only at a very late stage, when a URL is provided by users- can't easily pass arround the auth manager without coupling the components- have to recreate a new auth manager instance if the user logs out and logs in to a different URL- service locator needs to be passed around because this is the actual factory of oauth managers in ToolboxInstead, we went with a differet approach, COderOAuthManager will derive and store the refresh configs oncethe authorization config is received. If the user logs out and logs in to a different URL the refresh data isalso guaranteed to be updated. And on top of that - this approach allows us to get rid of all of the issuesmentioned above.
    @fioan89
    fioan89 committedOct 14, 2025
    Configuration menu
    Copy the full SHA
    decb082View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d432a76View commit details
    Browse the repository at this point in the history
  3. impl: handle the redirect URI

    Toolbox can handle automatically the exchange of an authorization code with a tokenby handling the custom URI for oauth. This commit calls the necessary APIin the Coder Toolbox URI handling.
    @fioan89
    fioan89 committedOct 14, 2025
    Configuration menu
    Copy the full SHA
    2a28ceeView commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2025

  1. fix: wrong client app registration endpoint

    POST /api/v2/oauth2-provider/apps is actually for manual adminregistration for admin created apps. Programmatic Dynamic ClientRegistration is done via `POST /oauth2/register`.At the same time I included `registration_access_token` and `registration_client_uri`to use it later in order to refresh the client secret without re-registering the client app.
    @fioan89
    fioan89 committedOct 16, 2025
    Configuration menu
    Copy the full SHA
    6462f14View commit details
    Browse the repository at this point in the history
  2. impl: simple way of triggering the OAuth flow.

    A bunch of code thrown around to launch the OAuth flow.Still needs a couple of things:- persist the client id and registration uri and token- re-use client id instead of re-register every time- properly handle scenarios where OAuth is not available- the OAuth right now can be enabled if we log out and thenhit next in the deployment screen
    @fioan89
    fioan89 committedOct 16, 2025
    Configuration menu
    Copy the full SHA
    0e46da0View commit details
    Browse the repository at this point in the history
Loading

[8]ページ先頭

©2009-2025 Movatter.jp