Commita3651ba

committed

fix: compare builds instead of statuses

when updating the workspace and agent. Checking the status issubtly different from checking if there is a new build in the following scenario:1. Latest build is failed.2. The poll runs, so we currently have failed stored as the status.3. User starts workspace, we set to queued.4. Build fails again (a brand-new build, but it is also failing).5. Poll runs again, checks failed against the last status, which is also failed,so it leaves the status as queued, even though the workspace is actually failedcurrently, so really we do want to update the state to failed.So we could miss updates from one build to another build when both builds end up with the same status.

1 parentfa8f6ac commita3651baCopy full SHA for a3651ba

File tree

1 file changed

-5

lines changed

src/main/kotlin/com/coder/toolbox
- CoderRemoteEnvironment.kt

1 file changed

-5

lines changed

`‎src/main/kotlin/com/coder/toolbox/CoderRemoteEnvironment.kt‎`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -260,11 +260,7 @@ class CoderRemoteEnvironment(`
`260`	`260`	`* Update the workspace/agent status to the listeners, if it has changed.`
`261`	`261`	`*/`
`262`	`262`	`funupdate(workspace:Workspace,agent:WorkspaceAgent) {`
`263`		`-if (WorkspaceAndAgentStatus.from(this.workspace,this.agent)==WorkspaceAndAgentStatus.from(`
`264`		`- workspace,`
`265`		`- agent`
`266`		`- )`
`267`		`- ) {`
	`263`	`+if (this.workspace.latestBuild== workspace.latestBuild) {`
`268`	`264`	`return`
`269`	`265`	`}`
`270`	`266`	`this.workspace= workspace`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita3651ba

File tree

1 file changed

1 file changed

`‎src/main/kotlin/com/coder/toolbox/CoderRemoteEnvironment.kt‎`

0 commit comments