Commit6462f14

committed

fix: wrong client app registration endpoint

POST /api/v2/oauth2-provider/apps is actually for manual adminregistration for admin created apps. Programmatic Dynamic ClientRegistration is done via `POST /oauth2/register`.At the same time I included `registration_access_token` and `registration_client_uri`to use it later in order to refresh the client secret without re-registering the client app.

1 parent2a28cee commit6462f14Copy full SHA for 6462f14

File tree

2 files changed

-4

lines changed

src/main/kotlin/com/coder/toolbox/oauth
- ClientRegistrationResponse.kt
- CoderAuthorizationApi.kt

2 files changed

-4

lines changed

`‎src/main/kotlin/com/coder/toolbox/oauth/ClientRegistrationResponse.kt‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -17,5 +17,7 @@ data class ClientRegistrationResponse(`
`17`	`17`	`@field:Json(name = "scope")valscope:String,`
`18`	`18`	`@field:Json(name = "token_endpoint_auth_method")valtokenEndpointAuthMethod:String,`
`19`	`19`	`@field:Json(name = "client_id_issued_at")valclientIdIssuedAt:Long?,`
`20`		`- @field:Json(name = "client_secret_expires_at")valclientSecretExpiresAt:Long?`
	`20`	`+ @field:Json(name = "client_secret_expires_at")valclientSecretExpiresAt:Long?,`
	`21`	`+ @field:Json(name = "registration_client_uri")valregistrationClientUri:String,`
	`22`	`+ @field:Json(name = "registration_access_token")valregistrationAccessToken:String`
`21`	`23`	`)`

`‎src/main/kotlin/com/coder/toolbox/oauth/CoderAuthorizationApi.kt‎`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,15 +4,13 @@ import retrofit2.Response`
`4`	`4`	`importretrofit2.http.Body`
`5`	`5`	`importretrofit2.http.GET`
`6`	`6`	`importretrofit2.http.POST`
`7`		`-importretrofit2.http.Url`
`8`	`7`
`9`	`8`	`interfaceCoderAuthorizationApi {`
`10`	`9`	`@GET(".well-known/oauth-authorization-server")`
`11`	`10`	`suspendfundiscoveryMetadata():Response<AuthorizationServer>`
`12`	`11`
`13`		`- @POST`
	`12`	`+ @POST("oauth2/register")`
`14`	`13`	`suspendfunregisterClient(`
`15`		`- @Urlurl:String,`
`16`	`14`	`@Bodyrequest:ClientRegistrationRequest`
`17`	`15`	`):Response<ClientRegistrationResponse>`
`18`	`16`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6462f14

File tree

2 files changed

2 files changed

`‎src/main/kotlin/com/coder/toolbox/oauth/ClientRegistrationResponse.kt‎`

`‎src/main/kotlin/com/coder/toolbox/oauth/CoderAuthorizationApi.kt‎`

0 commit comments