Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add support for RDP URIs#87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 3 commits intomainfromspike/open-rdp-handler
May 8, 2025
Merged

Conversation

spikecurtis
Copy link
Collaborator

@spikecurtisspikecurtis commentedMay 6, 2025•
edited
Loading

Adds basic support forcoder:/ URIs for opening RDP.

relates to#52 but I still need to add support for checking the authority.

@spikecurtisGraphite App
Copy link
CollaboratorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewMay 6, 2025 06:52
@spikecurtisspikecurtisforce-pushed thespike/open-rdp-handler branch from3115c93 to5378529CompareMay 6, 2025 06:54
Comment on lines +18 to +21
Serilog.Log.Logger = new LoggerConfiguration().MinimumLevel.Debug().WriteTo.NUnitOutput().CreateLogger();
var builder = Host.CreateApplicationBuilder();
builder.Services.AddSerilog();
var logger = (ILogger<UriHandler>)builder.Build().Services.GetService(typeof(ILogger<UriHandler>))!;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Creating an application builder for this seems excessive as it's only being used to createILogger instances. Is there no way to just get anILogger from serilog and pass that through without using application hosting?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If there is, I haven't figured it out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

😢

@spikecurtisspikecurtis merged commit2a4814e intomainMay 8, 2025
4 checks passed
@spikecurtisGraphite App
Copy link
CollaboratorAuthor

Merge activity

@spikecurtisspikecurtis deleted the spike/open-rdp-handler branchMay 8, 2025 09:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp