Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add workspace app icons to tray window#86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 15 commits intomainfromdean/app-buttons
May 12, 2025

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedMay 6, 2025•
edited
Loading

  • AddsAgentAppViewModel to handle each button
  • Adds collapsible control components to handle the collapsing section
  • AddsUuid type to work around issues with the built-inGuid type
  • AddsModelMerge utility for merging lists with minimal updates to work around constant flashing in the UI

TODO:

  • Auto expand the first agent (to match macOS)
  • Only allow one agent to be expanded at a time (to match macOS)
  • Add tests forModelMerge
  • Get rid of the SVG size constants inAgentAppViewModel since I don't think they do anything
  • Add$SESSION_TOKEN replacement
  • Display icons for vscode and vscode insiders

Known issues:

  • /icon/cursor.svg seems to be an SVG with an embedded PNG, which I guess can't be rendered properly by WinUI
buttons.mp4

Closes#50

matifali reacted with heart emoji
- Adds AgentAppViewModel to handle each button- Adds collapsible control components to handle the collapsing section- Adds Uuid type to work around issues with the built-in Guid type- Adds ModelMerge utility for merging lists with minimal updates to work  around constant flashing in the UI
Copy link
Collaborator

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't finish looking at all the files, but it looks like you're still doing some stuff, so I'll get another look later anyway. It's the end of my day so sending the comments I have so you'll have them to look at in the morning.


public partial class CoderApiClient
{
public Task<WorkspaceAgent> GetWorkspaceAgent(string id, CancellationToken ct = default)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This would be safer if we accepted a UUID, rather than a string, which could totally change the endpoint we hit.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I considered this but didn't want to add a dependency betweenCoderSdk andVpn.Proto, and adding a new project for just a UUID type seems overkill. The Go codersdk package accepts string IDs for some methods as well, so I think it's fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I had (wrongly) assumed/remembered that we parsed theAgent protobufs into a model withGuid id types. But, we just leave it as a byte string. You're right, not worth introducing the dep.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could we move ourUuid implementation to CoderSdk? There will likely be plenty of times we want to interact with UUIDs outside of the protobuf protocols.


public partial class CoderApiClient
{
public Task<WorkspaceAgent> GetWorkspaceAgent(string id, CancellationToken ct = default)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could we move ourUuid implementation to CoderSdk? There will likely be plenty of times we want to interact with UUIDs outside of the protobuf protocols.

/// 4122 compliance, but it should provide enough coverage for Coder
/// Desktop.
/// </summary>
public class Uuid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we move this to CoderSdk?

@spikecurtisGraphite App
Copy link
Collaborator

I suggested we moveUuid to CoderSdk, but I don't need to review again.

@deansheatherdeansheatherenabled auto-merge (squash)May 12, 2025 17:09
@deansheatherdeansheather merged commita6f7bb6 intomainMay 12, 2025
3 checks passed
@deansheatherdeansheather deleted the dean/app-buttons branchMay 12, 2025 17:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

@ethanndicksonethanndicksonAwaiting requested review from ethanndickson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button Auto-Population for External Apps
3 participants
@deansheather@spikecurtis@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp