Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add remote directory picker to file sync#73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 5 commits intomainfromdean/remote-dir-picker
May 1, 2025

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedApr 22, 2025•
edited
Loading

Adds a new remote directory picker window used when creating a file sync to select the remote directory.

NVIDIA_Overlay_LplyNOug3n.mp4

TODOs:

  • Use a dropdown for picking workspace agent in the file sync UI, currently it's typed out (and will crash if empty lol)
  • Fix reactivation of the window, try to make it function like any other system dialog window

Closes#27

Adds a new remote directory picker window used when creating a file syncto select the remote directory.
@deansheatherdeansheather marked this pull request as draftApril 22, 2025 14:56
@deansheather
Copy link
MemberAuthor

It's ready for review, just need to finish the few TODOs

@deansheatherdeansheather marked this pull request as ready for reviewApril 23, 2025 03:45
TextTrimming="CharacterEllipsis"
IsTextTrimmedChanged="TooltipText_IsTextTrimmedChanged"
Margin="0,0,0,10" />
<ProgressRing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a nice touch

[RelayCommand]
private void StartCreatingNewSession()
{
ClearNewForm();
// Ensure we have a fresh hosts list before we open the form.
SetAvailableHostsFromRpcModel(_rpcController.GetState());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It might be a little annoying to find that the available hosts only updates when you click the button to create a new session. I could imagine starting up a workspace, then creating a new session to find your workspace isn't yet listed. To get it to populate you need to cancel out, then wait for it to start, maybe by watching the tray menu, then create a new sync session.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If any entries get added or removed while the selector is broken it messes up the selector

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lame. I guess we can see if it's annoying in practice.

deansheather reacted with thumbs up emoji
@deansheatherdeansheatherenabled auto-merge (squash)May 1, 2025 02:00
@deansheatherdeansheather merged commite200dd4 intomainMay 1, 2025
3 checks passed
@deansheatherdeansheather deleted the dean/remote-dir-picker branchMay 1, 2025 02:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

@ethanndicksonethanndicksonAwaiting requested review from ethanndickson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add remote folder picker to file sync GUI
2 participants
@deansheather@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp