chore: rework mutagen controller, add polling#65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deansheather merged 5 commits intodean/sync-wiringfromdean/mutagen-controller-rework

Apr 2, 2025

Merged

chore: rework mutagen controller, add polling#65

deansheather merged 5 commits intodean/sync-wiringfromdean/mutagen-controller-rework

Apr 2, 2025

Conversation

Copy link

Member

deansheather commentedApr 1, 2025

Use locks during operations for daemon process consistency
Use a state model for UI rendering
Use events to signal state changes
Fix some tooltip problems that arise from polling

chore: rework mutagen controller, add polling

eeaf6f9

- Use locks during operations for daemon process consistency- Use a state model for UI rendering- Use events to signal state changes- Fix some tooltip problems that arise from polling

deansheather requested a review fromspikecurtis

April 1, 2025 01:46

spikecurtis reviewed

Apr 1, 2025

View reviewed changes

App/Services/MutagenController.cs OutdatedShow resolvedHide resolved

App/Services/MutagenController.cs Outdated

		_state = state;
		// Since the event handlers could block (or call back the
		// CredentialManager and deadlock), we run these in a new task.
		if (StateChanged == null) return;

Copy link

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't we need to check if the state has actually changed?

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I decided not to implement equality for the state type because I would also need to implement equality for the sync session model (and all of it's sub types) which seems like a lot. I don't think there's any side effects of calling this every time it changes though

App/Services/MutagenController.csShow resolvedHide resolved

App/Services/MutagenController.cs Outdated

		// Since the event handlers could block (or call back the
		// CredentialManager and deadlock), we run these in a new task.
		if (StateChanged == null) return;
		Task.Run(() => { StateChanged?.Invoke(this, state); });