Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: wire up file sync window#64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 5 commits intomainfromdean/sync-wiring
Apr 2, 2025
Merged

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedMar 26, 2025•
edited
Loading

  • AddsPauseSyncSession andResumeSyncSession
  • AddsSyncSessionViewModel that wrapsSyncSessionModel and adds view methods (as you cannot access the parent context if you're in aItemsRepeater apparently)
  • Wires up Initialize, List, Pause, Resume, Terminate and Create in the file sync UI

TODO:

  • Prevent the app from loading until mutagen finishes initializing (either successfully or not) (in a different PR)
  • Add reinitialization logic to mutagen controller (in a different PR)

Closes#26
Closes#28
Closes#29

@deansheatherdeansheather marked this pull request as ready for reviewMarch 28, 2025 12:37
Copy link
Collaborator

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Ssh,
}

public class CreateSyncSessionRequestEndpoint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just wondering out loud: these names are getting really long... is it C# style to namespace them rather than have a long prefix?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure what the convention is. Another option would be to move these inside the "parent type" e.g.new CreateSyncSessionRequest.Endpoint().

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That makes sense to me since they are only used to fully define theCreateSyncSessionRequest type

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Renamed these to:

  • CreateSyncSessionRequest.Endpoint
  • CreateSyncSessionRequest.Endpoint.ProtocolKind (can't beProtocol or it conflicts with the property with the same name)

So the names are longer when using them, but they're segregated and not cluttering up the main namespace

- Use locks during operations for daemon process consistency- Use a state model for UI rendering- Use events to signal state changes- Fix some tooltip problems that arise from polling
@deansheatherdeansheather merged commit8f60b4d intomainApr 2, 2025
3 checks passed
@deansheatherdeansheather deleted the dean/sync-wiring branchApril 2, 2025 07:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@deansheather@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp