Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add SizedFrame for window sizing#54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 2 commits intomainfromdean/sign-in-revamp
Mar 14, 2025

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedMar 11, 2025
edited
Loading

First part of sign-in revamp.

Adds aSizedFrame to unify some of the quirky window sizing code, as it's now used inSignInWindow as well asTrayWindow.

It'll also be used inFileSyncListWindow

matifali reacted with hooray emoji
@deansheatherdeansheather changed the titlefeat: revamp sign-in screenchore: add SizedFrame for window sizingMar 12, 2025
@deansheatherdeansheather marked this pull request as ready for reviewMarch 12, 2025 00:05
Copy link
Collaborator

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but need to fix Width vs Height (comment inline). I don't need to review again.

{
ResizeWindow();
ResizeWindow(e.NewSize.Width);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
ResizeWindow(e.NewSize.Width);
ResizeWindow(e.NewSize.Height);

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤦

@deansheatherdeansheatherenabled auto-merge (squash)March 14, 2025 07:25
@deansheatherdeansheather merged commit24853b0 intomainMar 14, 2025
3 checks passed
@deansheatherdeansheather deleted the dean/sign-in-revamp branchMarch 14, 2025 07:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@deansheather@spikecurtis

[8]ページ先頭

©2009-2025 Movatter.jp