- Notifications
You must be signed in to change notification settings - Fork10
chore: add SizedFrame for window sizing#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
spikecurtis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but need to fix Width vs Height (comment inline). I don't need to review again.
Uh oh!
There was an error while loading.Please reload this page.
App/Views/TrayWindow.xaml.cs Outdated
| privatevoidRootFrame_SizeChanged(objectsender,SizedFrameEventArgse) | ||
| { | ||
| ResizeWindow(); | ||
| ResizeWindow(e.NewSize.Width); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ResizeWindow(e.NewSize.Width); | |
| ResizeWindow(e.NewSize.Height); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🤦
24853b0 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
First part of sign-in revamp.
Adds a
SizedFrameto unify some of the quirky window sizing code, as it's now used inSignInWindowas well asTrayWindow.It'll also be used in
FileSyncListWindow