- Notifications
You must be signed in to change notification settings - Fork8
chore: add MutagenSdk project#48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Contains a gRPC client for mutagen's synchronization API.All required .proto files are vendored using a new script`Update-Proto.ps1`, which finds all required files by scanning `import`directives.The vendored files are modified to add `csharp_namespace` and a MITlicense header from mutagen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Few nits and suggestions inline
MutagenSdk/Update-Proto.ps1 Outdated
| & git.exe clone ` | ||
| --depth 1 ` | ||
| --branch $mutagenTag ` | ||
| "https://github.com/mutagen-io/mutagen.git" ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should use Coder's fork:https://github.com/coder/mutagen
Unfortunately, we are going to have to modify Mutagen and build our own releases to work around the SSH directory bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We don't have a v0.18.1 tag in our fork. We probably need to resync it so we get all of the tags etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Once we sort out the tags I'd be down to fix this in a follow up
| if ($LASTEXITCODE -ne 0) { throw "Failed to checkout $mutagenTag" } | ||
| } | ||
| } | ||
| finally { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
man, PowerShell is so much nicer than bash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
isn't the throw/try/catch/finally stuff just the best! I just wish they didn't go whole hog on making their own (usually worse) version of utilities that are available on Linux. At leastcurl.exe is available or I would cry
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Spike Curtis <spike@coder.com>
@spikecurtis the Join-Path fix was added in Powershell 6.0 but Windows 11 ships with 5.1 (or at least that's what I have installed). It's like macos vs linux bash all over again |
8e6ec03 intomainUh oh!
There was an error while loading.Please reload this page.
Closescoder/internal#379Much like incoder/coder-desktop-windows#48, this PR adds `mutagen-proto.sh` which finds all required files, following `import`s. Right now, we use this client to stop the daemon over gRPC.
Uh oh!
There was an error while loading.Please reload this page.
Contains a gRPC client for mutagen's synchronization API.
All required .proto files are vendored using a new script
Update-Proto.ps1, which finds all required files by scanningimportdirectives.The vendored files are modified to add
csharp_namespaceand a MIT license header from mutagen.Example usage:
Closecoder/internal#378