coder/coder-desktop-windowsPublic

NotificationsYou must be signed in to change notification settings
Fork3
Star14

feat: installer and uninstaller#32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deansheather merged 3 commits intomainfromdean/installer

Mar 1, 2025

Merged

feat: installer and uninstaller#32

deansheather merged 3 commits intomainfromdean/installer

Mar 1, 2025

Conversation

Copy link

Member

deansheather commentedFeb 28, 2025•
edited
Loading

Adds new packageInstaller which usesWixSharp to build WixToolset installers for WIndows.

We build two installers:

Coder Desktop (Core), which installs the app files, service files, VPN files (wintun.dll), creates a system service and an app shortcut in the start menu
Coder Desktop, which will netinstall the .NET runtime if it's not installed and then chain install `Coder Desktop (Core)

We will only be shipping theCoder Desktop installer, which contains the Core installer. The chained Core installation doesn't show up in Settings > Apps.

Follow-up PR will integrate to CI and add authenticode signing to the installer binaries.

Closes#11
Closes#30

feat: installer

f1c116a

deansheather requested review fromsreya,spikecurtis andethanndickson

February 28, 2025 02:02

ethanndickson reviewed

Feb 28, 2025

View reviewed changes

Copy link

Member

ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

works on my machine! 🎉 🎉 🎉

ethanndickson reviewed

Feb 28, 2025

View reviewed changes

scripts/files/logo.png

Copy link

Member

ethanndicksonFeb 28, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor, but we use a flat black icon on macOS from thepresskit. You very rarely see this app/executable icon during normal usage on either OS though.

Copy link

MemberAuthor

deansheatherFeb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Atif commented on the icon in Slack and I said it's something we can fix after we get alpha out, pretty much just involves someone designer-y redoing all of the assets in that dir + thecoder.ico and banner BMP in the coder/coder repo for the old installer.

I think for these icons we want something with a background, like maybe a black square with a white icon or something. Otherwise it'll look weird on the wrong system light/dark theme.