Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: added latency tooltips on workspaces#134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ibetitsmike merged 5 commits intomainfrommike/106-latency-on-workspaces
Jun 26, 2025

Conversation

ibetitsmike
Copy link
Contributor

@ibetitsmikeibetitsmike commentedJun 23, 2025
edited
Loading

Fixes:#106

image
image


// For compatibility with older deployments, we assume that if the
// last ping is null, the agent is healthy.
var isLatencyAcceptable = agent.LastPing != null ? agent.LastPing.Latency.ToTimeSpan() < HealthyPingThreshold : true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Did you check that the behavior of the C# protobuf library does this? They usually just use a zero value when it's not set to be consistent with other protobuf implementations

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, for reference types it will be null.

: AgentConnectionStatus.Yellow;
var connectionStatus = AgentConnectionStatus.Healthy;

if (agent.LastHandshake != null && agent.LastHandshake.ToDateTime() != default && agent.LastHandshake.ToDateTime() < DateTime.UtcNow)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

description.Append(ConnectionStatus.ToDisplayString());
}
if (LastHandshake != null)
description.Append($"\n\nLast handshake: {LastHandshake?.ToString()}");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have a relative timestamp (i.e.5 seconds ago) here but I actually gotta get rid of it, so this is fine.
( Have to get rid of it cause it only gets rendered once, and doesn't update on tooltip re-hovers 😦 )

ibetitsmike reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, I check for Default and set to null in the viewmodel cause showing a made up handshake just felt wrong.

@ibetitsmikeibetitsmike merged commitb8d7993 intomainJun 26, 2025
3 checks passed
@ibetitsmikeibetitsmike deleted the mike/106-latency-on-workspaces branchJune 26, 2025 09:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather left review comments

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show latency on workspace view
3 participants
@ibetitsmike@deansheather@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp