- Notifications
You must be signed in to change notification settings - Fork10
feat: added icon to installer's bootstrap application#112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| publicstringWindowsAppSdkPath{get;set;} | ||
| [Option('t',"theme-xml-path",Required=false,HelpText="Path to the theme .xml file to use for the installer")] | ||
| publicstringThemeXmlPath{get;set;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should bestring? if it's nullable
ibetitsmikeJun 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nope. This construct doesn't exist in .NET 4.8.1. Boxed type only applies to int, double, etc. iestring is explicitly nullable in that .NET version.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
23f7819 intomainUh oh!
There was an error while loading.Please reload this page.
Closes:#38
WiX 5 introduced a bug that stopped respecting the icon file on the theme's Window. This is described in this issue:wixtoolset/issues#8104
This PR introduces:
build-bootstrapperto allow optional setting of thetheme xml,RtfLargeTheme.xmlfrom WiX5.0.2with the added attribute ofIconFile