Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: added icon to installer's bootstrap application#112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ibetitsmike merged 3 commits intomainfrommike/38-added-icon-bootstrapper
Jun 2, 2025

Conversation

ibetitsmike
Copy link
Contributor

Closes:#38

WiX 5 introduced a bug that stopped respecting the icon file on the theme's Window. This is described in this issue:wixtoolset/issues#8104

This PR introduces:

  • an additional option in ourbuild-bootstrapper to allow optional setting of thetheme xml,
  • adds a copy of theRtfLargeTheme.xml from WiX5.0.2 with the added attribute ofIconFile

image

@@ -119,6 +119,9 @@ public class BootstrapperOptions : SharedOptions
[Option('w', "windows-app-sdk-path", Required = true, HelpText = "Path to the Windows App Sdk package to embed")]
public string WindowsAppSdkPath { get; set; }

[Option('t', "theme-xml-path", Required = false, HelpText = "Path to the theme .xml file to use for the installer")]
public string ThemeXmlPath { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should bestring? if it's nullable

Copy link
ContributorAuthor

@ibetitsmikeibetitsmikeJun 2, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nope. This construct doesn't exist in .NET 4.8.1. Boxed type only applies to int, double, etc. iestring is explicitly nullable in that .NET version.

deansheather reacted with thumbs up emoji
@ibetitsmikeibetitsmikeenabled auto-merge (squash)June 2, 2025 11:36
@ibetitsmikeibetitsmike merged commit23f7819 intomainJun 2, 2025
3 checks passed
@ibetitsmikeibetitsmike deleted the mike/38-added-icon-bootstrapper branchJune 2, 2025 17:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows installer doesn't have an icon while running
2 participants
@ibetitsmike@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp