- Notifications
You must be signed in to change notification settings - Fork3
chore: publish to winget in release workflow#108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Sync fork and submit updated manifest to winget-pkgs.- Install wingetcreate for submission.- Fetch git tags to fix lightweight tag issue.- Comment on PR after submission.- Use outputs from release job to manage versions.- Manage installer URLs dynamically for different architectures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Secret added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Adds a new Winget publication step to the release workflow by exposing the release version and defining a dedicated job to sync the winget-pkgs fork, update the manifest, and comment on the resulting PR.
- Expose the
versionoutput from thereleasejob. - Introduce a
wingetjob to sync the fork, installwingetcreate, submit the updated manifest, and comment on the PR. - Dynamically fetch installer URLs and automate PR notification.
Comments suppressed due to low confidence (1)
.github/workflows/release.yaml:123
- [nitpick] The
wingetjob name is generic; renaming it to something likepublish-wingetwould clarify its role in the workflow.
winget:Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| GH_TOKEN: ${{ secrets.CDRCI_GITHUB_TOKEN }} | ||
| - name: Checkout | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[nitpick] Pinningactions/checkout to a specific commit SHA can hinder updates; consider using a semver tag (e.g.,v4) to receive non-breaking fixes and improvements automatically.
| uses:actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683# v4.2.2 | |
| uses:actions/checkout@v4# v4.2.2 |
Copilot uses AI. Check for mistakes.
2301c75 intomainUh oh!
There was an error while loading.Please reload this page.
This is adapted from already tested
coder/coderworkflow.https://github.com/coder/coder/blob/afaa20e1663e773c3f490cba2419ad9217b537f6/.github/workflows/release.yaml#L808-L895