Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix daemon.lock race on mutagen startup#101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/daemon-startup-race
May 14, 2025

Conversation

spikecurtis
Copy link
Collaborator

@spikecurtisspikecurtis commentedMay 13, 2025
edited
Loading

I found the source of the issue where mutagen would fail to acquire the lock ondaemon.lock at startup.

The MutagenClient attempts to lock thedaemon.lock file while it is starting, so that it can fail fast if the daemon is not running.

While well meaning, this creates a race condition because as soon as we start the daemon process we create a MutagenClient so that we can talk to the daemon over its API. The MutagenClient might be holding the lock or have the lockfile open at the exact moment the daemon itself attempts to acquire and lock the file. The daemon immediately exits in that case and doesn't retry locking the file.

I've just removed the preflight checks on thedaemon.lock, since we don't want Coder Desktop to ever mess with that file (outside of tests).

@spikecurtisGraphite App
Copy link
CollaboratorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis self-assigned thisMay 13, 2025
@spikecurtisspikecurtis marked this pull request as ready for reviewMay 13, 2025 13:04
@spikecurtisspikecurtis merged commitcd845d4 intomainMay 14, 2025
4 checks passed
@spikecurtisspikecurtis deleted the spike/daemon-startup-race branchMay 14, 2025 05:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp