Commit39c41f4

committed

feat: add telemetry enrichment to StartRequest

1 parente0a11dd commit39c41f4Copy full SHA for 39c41f4

File tree

+251

-157

lines changed

+251

-157

lines changed

Lines changed: 34 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,34 @@`
	`1`	`+usingCoder.Desktop.Vpn.Proto;`
	`2`	`+usingCoder.Desktop.Vpn.Service;`
	`3`	`+`
	`4`	`+namespaceCoder.Desktop.Tests.Vpn.Service;`
	`5`	`+`
	`6`	`+[TestFixture]`
	`7`	`+publicclassTelemetryEnricherTest`
	`8`	`+{`
	`9`	`+[Test]`
	`10`	`+publicvoidEnrichStartRequest()`
	`11`	`+{`
	`12`	`+varreq=newStartRequest`
	`13`	`+{`
	`14`	`+CoderUrl="https://coder.example.com",`
	`15`	`+};`
	`16`	`+varenricher=newTelemetryEnricher();`
	`17`	`+req=enricher.EnrichStartRequest(req);`
	`18`	`+`
	`19`	`+// quick sanity check that non-telemetry fields aren't lost or overwritten`
	`20`	`+Assert.That(req.CoderUrl,Is.EqualTo("https://coder.example.com"));`
	`21`	`+`
	`22`	`+Assert.That(req.DeviceOs,Is.EqualTo("Windows"));`
	`23`	`+// seems that test assemblies always set 1.0.0.0`
	`24`	`+Assert.That(req.CoderDesktopVersion,Is.EqualTo("1.0.0.0"));`
	`25`	`+Assert.That(req.DeviceId,Is.Not.Empty);`
	`26`	`+vardeviceId=req.DeviceId;`
	`27`	`+`
	`28`	`+// deviceId is different on different machines, but we can test that`
	`29`	`+// each instance of the TelemetryEnricher produces the same value.`
	`30`	`+enricher=newTelemetryEnricher();`
	`31`	`+req=enricher.EnrichStartRequest(newStartRequest());`
	`32`	`+Assert.That(req.DeviceId,Is.EqualTo(deviceId));`
	`33`	`+}`
	`34`	`+}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ namespace Coder.Desktop.Vpn.Proto;`
`5`	`5`	`/// </summary>`
`6`	`6`	`publicclassRpcVersion`
`7`	`7`	`{`
`8`		`-publicstaticreadonlyRpcVersionCurrent=new(1,0);`
	`8`	`+publicstaticreadonlyRpcVersionCurrent=new(1,1);`
`9`	`9`
`10`	`10`	`publiculongMajor{get;}`
`11`	`11`	`publiculongMinor{get;}`

Comments

(0)