Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(build): switch to pkg based installer#92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ThomasK33 merged 1 commit intomainfromthomask33/pkg-installer
Mar 7, 2025

Conversation

ThomasK33
Copy link
Member

Change-Id: Ie3ef4fe53faa0af947493e58b81c523c040400a5
Signed-off-by: Thomas Kosiewskitk@coder.com

@ThomasK33Graphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 marked this pull request as ready for reviewMarch 6, 2025 12:47
@ThomasK33ThomasK33 linked an issueMar 6, 2025 that may beclosed by this pull request
@ThomasK33ThomasK33force-pushed thethomask33/pkg-installer branch 2 times, most recently fromfe28ae5 to1de6f23CompareMarch 6, 2025 13:37
@ThomasK33ThomasK33force-pushed thethomask33/pkg-installer branch from1de6f23 toe8c8297CompareMarch 6, 2025 13:53
Change-Id: Ie3ef4fe53faa0af947493e58b81c523c040400a5Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed thethomask33/pkg-installer branch frome8c8297 to99fff54CompareMarch 6, 2025 14:07
@ThomasK33ThomasK33 merged commitb88b08a intomainMar 7, 2025
4 checks passed
@ThomasK33Graphite App
Copy link
MemberAuthor

Merge activity

  • Mar 6, 7:56 PM EST: A user merged this pull request withGraphite.

@deansheatherdeansheather deleted the thomask33/pkg-installer branchMarch 7, 2025 07:38
ethanndickson added a commit that referenced this pull requestApr 15, 2025
One thing I noticed as part of my work on#121 is that our attempted fix introduced in#92 wasn't working as expected if the user had a VPN configuration installed before#86. This PR fetches the unique name of the VPN service dynamically, as part of the script, such that the service is started and stopped regardless of whether the service is called "Coder" or the older "CoderVPN".This also ensures we don't break it again if we ever change that name, such as to "Coder Connect" (I don't totally recall why it was set to "Coder", but I don't mind it)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor installer to be a PKG
2 participants
@ThomasK33@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp