Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: handle missing usertheme_preference on sign in#91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/handle-breaking-user-response
Mar 6, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMar 6, 2025•
edited
Loading

coder/coder#16564 has the Coder server no longer send thetheme_preference field in a/api/v2/user response.

The SwiftJSONDecoder requires that a missing field be explicitly marked as optional, else the deserialization fails. To make it less likely this happens again, we'll only requireid andusername be present.
We'll do the same for the other SDK types and only require the minimum fields the app needs be present.

This PR also improves the error message on any decoding error:
Screenshot 2025-03-06 at 1 35 33 pm

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewMarch 6, 2025 02:47
@ethanndicksonethanndickson self-assigned thisMar 6, 2025
@ethanndicksonethanndicksonforce-pushed theethan/handle-breaking-user-response branch from404de0d toff5b5c0CompareMarch 6, 2025 02:52
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMar 6, 2025•
edited
Loading

Merge activity

  • Mar 5, 10:24 PM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Mar 5, 10:25 PM EST: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit2dee620 intomainMar 6, 2025
4 checks passed
@deansheatherdeansheather deleted the ethan/handle-breaking-user-response branchMarch 7, 2025 07:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@ThomasK33ThomasK33Awaiting requested review from ThomasK33

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp