Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add menubar tray#9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 3 commits intomainfromethan/menubar
Dec 6, 2024
Merged

feat: add menubar tray#9

ethanndickson merged 3 commits intomainfromethan/menubar
Dec 6, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedDec 5, 2024•
edited
Loading

Closes#7.

codervpn-happy.mov
codervpn-error.mov

sachk reacted with thumbs up emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndicksonforce-pushed theethan/menubar branch 2 times, most recently fromaaa4c62 to5ce4eaeCompareDecember 5, 2024 09:18
@ethanndicksonethanndickson marked this pull request as ready for reviewDecember 5, 2024 09:20
"originHash" : "726475d6c2c0355de7a4de72708853eaf53eb295e791efe2cc4b8eb5ce4e9ae8",
"pins" : [
{
"identity" : "fluid-menu-bar-extra",
Copy link
MemberAuthor

@ethanndicksonethanndicksonDec 5, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a drop-in replacement for SwiftUIMenuBarExtra, since the original kinda just sucks and doesn't handle resizing very well. It's used byhttps://github.com/Shopify/tophat, and is designed so that ifMenuBarExtra ever improves, you can just swap back.

Copy link
MemberAuthor

@ethanndicksonethanndicksonDec 5, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These are UI unit tests for different views (SwiftUI components). You cannot unit test inUITests, you can only simulate interactions with a built executable (of which there is currently no point doing).

Copy link
Collaborator

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm honestly just getting my feet wet here, so I don't have a lot constructive to add yet. It looks great in terms of the resulting UI.

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, and the swift seems fine

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedDec 6, 2024•
edited
Loading

Merge activity

  • Dec 5, 10:32 PM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Dec 5, 10:32 PM EST: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit2c1e8d3 intomainDec 6, 2024
1 check passed
@ethanndicksonethanndickson deleted the ethan/menubar branchJanuary 23, 2025 02:49
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build the tray menu
3 participants
@ethanndickson@spikecurtis@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp