- Notifications
You must be signed in to change notification settings - Fork5
chore: remove "VPN" from setting description#86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ThomasK33 merged 1 commit intomainfromthomask33/03-02-chore_remove_vpn_from_setting_descriptionMar 11, 2025
Merged
chore: remove "VPN" from setting description#86
ThomasK33 merged 1 commit intomainfromthomask33/03-02-chore_remove_vpn_from_setting_descriptionMar 11, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
ThomasK33 commentedMar 2, 2025
Member
ethanndickson commentedMar 3, 2025
Do we want to change it in the UI too? |
4405af0 tof99d936Comparef99d936 to17da969Compare2 tasks
ethanndickson approved these changesMar 11, 2025
Member
ethanndickson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There's one more inViews/Settings/LiteralHeadersSection.swift, I had it incorrectly asCoder VPN (with a space)
Change-Id: If1e0c81dd7188eea92f814424a997944a07caf86Signed-off-by: Thomas Kosiewski <tk@coder.com>
17da969 to3579523CompareMemberAuthor
ThomasK33 commentedMar 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
2094e9f intomain 4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ethanndickson added a commit that referenced this pull requestApr 15, 2025
One thing I noticed as part of my work on#121 is that our attempted fix introduced in#92 wasn't working as expected if the user had a VPN configuration installed before#86. This PR fetches the unique name of the VPN service dynamically, as part of the script, such that the service is started and stopped regardless of whether the service is called "Coder" or the older "CoderVPN".This also ensures we don't break it again if we ever change that name, such as to "Coder Connect" (I don't totally recall why it was set to "Coder", but I don't mind it)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Rename "CoderVPN" to "Coder Connect" in UI and system components