Improvement over the change in#76 - reconfigures on launch if the VPN is unconfigured, but an existing session is present inUserDefaults & Keychain.

Additionally:

Changes the waiting for connectivity timeout on the dylib download from 7 days to 15 seconds.
Sets the icon to the 'off' opacity on startup. Previously it was only set to 'off' on startup if the VPN was configured. If the VPN is connected on startup, it'll immediately go back to the 'on' opacity.

Copy link

MemberAuthor

ethanndickson commentedFeb 28, 2025

chore: reconfigure VPN on reinstall #84 👈(View in Graphite)
main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ethanndickson force-pushed theethan/reconfigure-on-reinstall branch frombe8e02f to194f4bbCompare

February 28, 2025 08:03

ethanndickson requested a review fromThomasK33

February 28, 2025 08:05

ethanndickson marked this pull request as ready for review

February 28, 2025 08:05

ethanndickson commented

Feb 28, 2025

View reviewed changes

Coder Desktop/Coder Desktop/Views/LoginForm.swift

		@@ -122,7 +122,7 @@ struct LoginForm: View {
		).disabled(true)
		}
		Section {
		SecureField("Session Token", text: $sessionToken, prompt: Text("●●●●●●●●"))

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also removed the prompt because it was a lil confusing, and also the dots were way too big with no way to change it.

Coder Desktop/VPN/Manager.swift Outdated

Comment on lines 33 to 36

		// URLSession's waiting for connectivity sometimes hangs even when
		// the network is up so this is deliberately short (15s) to avoid a
		// poor UX where it appears stuck.
		sessionConfig.timeoutIntervalForResource = 15

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a super weird bug, the VPN was stuck connecting after waking my laptop. However, when I cut my network connection, I saw a download failed error, which would suggest that's where it was stuck.

ethanndickson commented

Feb 28, 2025

View reviewed changes

Coder Desktop/Coder Desktop/Views/LoginForm.swift

		@@ -38,7 +38,7 @@ struct LoginForm: View {
		.animation(.easeInOut, value: currentPage)
		.onAppear {
		baseAccessURL = state.baseAccessURL?.absoluteString ?? baseAccessURL
		sessionToken = ""