Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: canvas preview panic in Xcode resolved#82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ThomasK33
Copy link
Member

@ThomasK33ThomasK33 commentedFeb 26, 2025•
edited
Loading

The preview was panicking because the app state had an optional base URL, which is getting unwrapped elsewhere. This creates an app state and then 'logs in' to set the base URL, reenabling the preview.

Change-Id: I8d6a19063a13f772dc409bc5e523e1af9c109bee
Signed-off-by: Thomas Kosiewskitk@coder.com

Change-Id: I8d6a19063a13f772dc409bc5e523e1af9c109beeSigned-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33Graphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 self-assigned thisFeb 26, 2025
@ThomasK33ThomasK33 marked this pull request as ready for reviewFebruary 26, 2025 17:22
@@ -25,6 +25,7 @@ class AppState: ObservableObject {
// Stored in Keychain
@Published private(set) var sessionToken: String? {
didSet {
guard persistent else { return }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is already guarded inkeychainSet

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh yes, it would have been wise of me to check that. 😅

I will keep it in for consistency with the setters above and below, as it appeared somewhat odd. This also ensures that we are doubly safe.

@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedFeb 27, 2025•
edited
Loading

Merge activity

  • Feb 27, 6:45 AM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Feb 27, 6:45 AM EST: A user merged this pull request withGraphite.

@ThomasK33ThomasK33 merged commit3a520d5 intomainFeb 27, 2025
4 checks passed
@deansheatherdeansheather deleted the thomask33/02-26-fix_canvas_preview_panic_in_xcode_resolved branchMarch 7, 2025 07:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ThomasK33@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp