Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: improve text contrast on light mode#80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/text-contrast
Feb 27, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedFeb 26, 2025
edited
Loading

I discovered you pretty much never want to usegray as a text colour.secondary is only gray where appropriate.
The menu bar tray is slightly transparent, and.secondary and.primary text colours account for that.
As seen below, dark mode is almost unchanged.

Light Mode

Before (on a dark background)

imageimage

After (on a dark background)

imageimage

Note: Apple's decided to makesecondary darker thanprimary in this case.

After (on a light background)

imageimage

Dark Mode

Before

imageimage

After

imageimage

matifali reacted with heart emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedFeb 26, 2025
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewFebruary 26, 2025 08:18
@ethanndicksonethanndickson self-assigned thisFeb 26, 2025
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedFeb 27, 2025
edited
Loading

Merge activity

  • Feb 26, 10:22 PM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Feb 26, 10:25 PM EST:Graphite rebased this pull request as part of a merge.
  • Feb 26, 10:27 PM EST: A user merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/reduce-err-verbosity tographite-base/80February 27, 2025 03:22
@ethanndicksonethanndickson changed the base branch fromgraphite-base/80 tomainFebruary 27, 2025 03:24
@ethanndicksonethanndickson merged commit5b4b174 intomainFeb 27, 2025
4 checks passed
@deansheatherdeansheather deleted the ethan/text-contrast branchMarch 7, 2025 07:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

@matifalimatifalimatifali approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ethanndickson@ThomasK33@matifali

[8]ページ先頭

©2009-2025 Movatter.jp