Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add homebrew cask release action#56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ThomasK33
Copy link
Member

@ThomasK33ThomasK33 commentedFeb 14, 2025•
edited
Loading

Adds homebrew cask auto-update workflow and improves VPN logging

This change adds a new workflow to automatically update the homebrew cask when
a new version of Coder Desktop is released. It also improves VPN logging by
adding more debug logs and making the logger static, to avoid race conditions.

Change-Id: I6e76a8fa519f378cda92b4edffa64c17294e01b9
Signed-off-by: Thomas Kosiewskitk@coder.com

@ThomasK33Graphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 marked this pull request as ready for reviewFebruary 14, 2025 11:22
@ThomasK33ThomasK33force-pushed the02-14-feat_add_homebrew_cask_release_action branch from5e831ab to38b2cd2CompareFebruary 14, 2025 11:26
@ThomasK33ThomasK33force-pushed the02-14-feat_add_homebrew_cask_release_action branch 6 times, most recently fromb1c132d to28b526eCompareFebruary 14, 2025 13:38
@ThomasK33ThomasK33 linked an issueFeb 14, 2025 that may beclosed by this pull request
2 tasks
@ThomasK33ThomasK33force-pushed the02-14-feat_add_homebrew_cask_release_action branch 3 times, most recently from01e1524 toa59b015CompareFebruary 14, 2025 14:38
matifali
matifali previously approved these changesFeb 14, 2025
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Except a few suggestions and the PR scope.

@matifalimatifali dismissed theirstale reviewFebruary 14, 2025 17:01

awaiting response.

@ThomasK33ThomasK33force-pushed the02-14-feat_add_homebrew_cask_release_action branch froma59b015 to352c6e1CompareFebruary 18, 2025 07:25
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nothing blocking except a suggestion on auto approval. Good to merge without that too.

Change-Id: I6e76a8fa519f378cda92b4edffa64c17294e01b9Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed the02-14-feat_add_homebrew_cask_release_action branch from352c6e1 tof9ba5a1CompareFebruary 18, 2025 11:32
@matifali

This comment was marked as outdated.

@matifalimatifali removed the request for review fromethanndicksonFebruary 18, 2025 11:42
@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedFeb 18, 2025•
edited
Loading

Merge activity

  • Feb 18, 6:52 AM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Feb 18, 6:52 AM EST: A user merged this pull request withGraphite.

@ThomasK33ThomasK33 merged commit53fc1e0 intomainFeb 18, 2025
4 checks passed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: since we're gonna do preview builds offmain we should probably call thisbuild.yml &name: build.

@@ -11,12 +11,12 @@ XCPROJECT := Coder\ Desktop/Coder\ Desktop.xcodeproj
SCHEME := Coder\ Desktop
SWIFT_VERSION := 6.0

CURRENT_PROJECT_VERSION=$(shell git describe --tags)
CURRENT_PROJECT_VERSION:=$(shell git describe --match 'v[0-9]*' --dirty='.devel' --always --tags)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I had to look this up but= is lazy,:= is eager - do we need eager here?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's more about not reevaluating the value assignment.
A simple= will result in continuous re-expansions of the variable.
A:=, on the other hand, will only be expanded once and then used as a "constant".

(https://www.gnu.org/software/make/manual/html_node/Simple-Assignment.html)

@ethanndicksonethanndickson deleted the 02-14-feat_add_homebrew_cask_release_action branchFebruary 18, 2025 11:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali approved these changes

@ethanndicksonethanndicksonethanndickson left review comments

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Homebrew formula
3 participants
@ThomasK33@matifali@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp