Ensures CURRENT_PROJECT_VERSION and MARKETING_VERSION are not empty when building the project, failing the build process with an error message if either variable cannot be determined from git tags.

Change-Id: I83265a11182df6d28f2ef3a5f5454adba27c95ea
Signed-off-by: Thomas Kosiewskitk@coder.com

Copy link

MemberAuthor

ThomasK33 commentedFeb 12, 2025

fix(Makefile): add version validation checks #44 👈(View in Graphite)
main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ThomasK33 changed the title~~fix(Makefile): add missing dollar sign and add assert for non empty version strings~~er

Feb 12, 2025

ThomasK33 changed the titleerfix(Makefile): add version validation checks

Feb 12, 2025

ThomasK33 requested a review fromethanndickson

February 12, 2025 15:03

ThomasK33 self-assigned this

Feb 12, 2025

ThomasK33 marked this pull request as ready for review

February 12, 2025 15:03

ThomasK33 force-pushed the02-12-fix_makefile_add_missing_dollar_sign_and_add_assert_for_non_empty_version_strings branch 2 times, most recently from2c83e83 to1af2771Compare

February 12, 2025 15:19

fix(Makefile): add missing dollar sign and add assert for non empty v…

9370b0a

…ersion stringsChange-Id: I83265a11182df6d28f2ef3a5f5454adba27c95eaSigned-off-by: Thomas Kosiewski <tk@coder.com>

ThomasK33 force-pushed the02-12-fix_makefile_add_missing_dollar_sign_and_add_assert_for_non_empty_version_strings branch from1af2771 to9370b0aCompare

February 12, 2025 15:27